linux-kernel - Re: [PATCH] hwmon: Correct struct allocation style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20190709012233.GA311@roeck-us.net>
Date:   Mon, 8 Jul 2019 18:22:33 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Fabian Schindlatz <fabian.schindlatz@....de>
Cc:     linux-hwmon@...r.kernel.org, Len Brown <len.brown@...el.com>,
        tglx@...utronix.de, Ingo Molnar <mingo@...nel.org>,
        Zhang Rui <rui.zhang@...el.com>, linux-kernel@...r.kernel.org,
        Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH] hwmon: Correct struct allocation style

Hi,

On Thu, Jun 27, 2019 at 05:27:38PM +0200, Fabian Schindlatz wrote:
> Use sizeof(*var) instead of sizeof(struct var_type) as argument to
> kalloc() and friends to comply with the kernel coding style.
> 
> Co-developed-by: Thomas Röthenbacher <thomas.roethenbacher@....de>
> Signed-off-by: Thomas Röthenbacher <thomas.roethenbacher@....de>
> Signed-off-by: Fabian Schindlatz <fabian.schindlatz@....de>
> [groeck: Resolved comment conflict against -next]
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>

This patch causes conflicts in -next due to commit 835896a59b95
("hwmon/coretemp: Cosmetic: Rename internal variables to zones
from packages"), which is not being submitted through the hwmon
subsystem. Unfortunately, the conflicts are more substantial than
I thought and not trivial. Since I have no control over the
conflicting patch, I decided to drop this patch from the hwmon
subsystem commit queue.

Please feel free to resubmit after the commit window closes.
I would suggest to drop the coretemp driver from the patch since
I don't know if further changes outside my control will be made
to that driver.

Sorry for the trouble.

Guenter