lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 9 Jul 2019 19:12:47 +0800 From: Wen Yang <wen.yang99@....com.cn> To: linux-kernel@...r.kernel.org Cc: xue.zhihong@....com.cn, wang.yi59@....com.cn, cheng.shengyu@....com.cn, Wen Yang <wen.yang99@....com.cn>, Scott Wood <oss@...error.net>, Kumar Gala <galak@...nel.crashing.org>, Benjamin Herrenschmidt <benh@...nel.crashing.org>, Paul Mackerras <paulus@...ba.org>, Michael Ellerman <mpe@...erman.id.au>, Markus Elfring <Markus.Elfring@....de>, linuxppc-dev@...ts.ozlabs.org Subject: [PATCH 1/2] powerpc/83xx: fix use-after-free in mpc831x_usb_cfg() The immr_node variable is still being used after the of_node_put() call, which may result in use-after-free. Fix this issue by calling of_node_put() after the last usage. Fixes: fd066e850351 ("powerpc/mpc8308: fix USB DR controller initialization") Signed-off-by: Wen Yang <wen.yang99@....com.cn> Cc: Scott Wood <oss@...error.net> Cc: Kumar Gala <galak@...nel.crashing.org> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org> Cc: Paul Mackerras <paulus@...ba.org> Cc: Michael Ellerman <mpe@...erman.id.au> Cc: Markus Elfring <Markus.Elfring@....de> Cc: linuxppc-dev@...ts.ozlabs.org Cc: linux-kernel@...r.kernel.org --- arch/powerpc/platforms/83xx/usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/platforms/83xx/usb.c b/arch/powerpc/platforms/83xx/usb.c index 3d247d7..19dcef5 100644 --- a/arch/powerpc/platforms/83xx/usb.c +++ b/arch/powerpc/platforms/83xx/usb.c @@ -158,11 +158,10 @@ int mpc831x_usb_cfg(void) iounmap(immap); - of_node_put(immr_node); - /* Map USB SOC space */ ret = of_address_to_resource(np, 0, &res); if (ret) { + of_node_put(immr_node); of_node_put(np); return ret; } @@ -203,6 +202,7 @@ int mpc831x_usb_cfg(void) out: iounmap(usb_regs); + of_node_put(immr_node); of_node_put(np); return ret; } -- 2.9.5
Powered by blists - more mailing lists