[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190709014436.GA9055@bogus>
Date: Mon, 8 Jul 2019 19:44:36 -0600
From: Rob Herring <robh@...nel.org>
To: Sricharan R <sricharan@...eaurora.org>
Cc: sboyd@...nel.org, linus.walleij@...aro.org, agross@...nel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-clk@...r.kernel.org, linux-gpio@...r.kernel.org,
linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/6] pinctrl: qcom: Add ipq6018 pinctrl driver
On Wed, Jun 05, 2019 at 10:58:53PM +0530, Sricharan R wrote:
> Add initial pinctrl driver to support pin configuration with
> pinctrl framework for ipq6018.
>
> Signed-off-by: Sricharan R <sricharan@...eaurora.org>
> Signed-off-by: Rajkumar Ayyasamy <arajkuma@...eaurora.org>
> Signed-off-by: speriaka <speriaka@...eaurora.org>
> ---
> .../bindings/pinctrl/qcom,ipq6018-pinctrl.txt | 186 +++
Please split bindings to separate patch. Using DT schema would be nice.
> drivers/pinctrl/qcom/Kconfig | 10 +
> drivers/pinctrl/qcom/Makefile | 1 +
> drivers/pinctrl/qcom/pinctrl-ipq6018.c | 1183 ++++++++++++++++++++
> 4 files changed, 1380 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.txt
> create mode 100644 drivers/pinctrl/qcom/pinctrl-ipq6018.c
Powered by blists - more mailing lists