linux-kernel - Re: [PATCH v2 03/19] arm64: renesas: Update 'vsps' property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 9 Jul 2019 14:10:05 +0100
From:   Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
To:     Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Jacopo Mondi <jacopo+renesas@...ndi.org>
Cc:     airlied@...ux.ie, daniel@...ll.ch, koji.matsuoka.xm@...esas.com,
        muroya@....co.jp, VenkataRajesh.Kalakodima@...bosch.com,
        Harsha.ManjulaMallikarjun@...bosch.com,
        linux-renesas-soc@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 03/19] arm64: renesas: Update 'vsps' property

Hi Jacopo,

On 08/07/2019 04:11, Laurent Pinchart wrote:
> Hi Jacopo,
> 
> Thank you for the patch.
> 
> On Sat, Jul 06, 2019 at 04:07:30PM +0200, Jacopo Mondi wrote:
>> Update the 'vsps' property in the R-Car Gen3 SoC device tree files to
>> match what's in in the documentation example.
>>
>> Signed-off-by: Jacopo Mondi <jacopo+renesas@...ndi.org>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

+1 from me too. This certainly improves readability/clarity IMO.

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>

> 
>> ---
>>  arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 2 +-
>>  arch/arm64/boot/dts/renesas/r8a7795.dtsi  | 2 +-
>>  arch/arm64/boot/dts/renesas/r8a77965.dtsi | 2 +-
>>  arch/arm64/boot/dts/renesas/r8a77990.dtsi | 2 +-
>>  arch/arm64/boot/dts/renesas/r8a77995.dtsi | 2 +-
>>  5 files changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
>> index 3f86db199dbf..e643f9d3c102 100644
>> --- a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
>> @@ -1807,7 +1807,7 @@
>>  			clocks = <&cpg CPG_MOD 724>,
>>  				 <&cpg CPG_MOD 723>;
>>  			clock-names = "du.0", "du.1";
>> -			vsps = <&vspd0 0 &vspd1 0>;
>> +			vsps = <&vspd0 0>, <&vspd1 0>;
>>  			status = "disabled";
>>  
>>  			ports {
>> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>> index 097538cc4b1f..432f4036a8a8 100644
>> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>> @@ -3098,7 +3098,7 @@
>>  				 <&cpg CPG_MOD 722>,
>>  				 <&cpg CPG_MOD 721>;
>>  			clock-names = "du.0", "du.1", "du.2", "du.3";
>> -			vsps = <&vspd0 0 &vspd1 0 &vspd2 0 &vspd0 1>;
>> +			vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>, <&vspd0 1>;
>>  			status = "disabled";
>>  
>>  			ports {
>> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>> index 2554b1742dbf..b701aeb4f438 100644
>> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>> @@ -2456,7 +2456,7 @@
>>  			clock-names = "du.0", "du.1", "du.3";
>>  			status = "disabled";
>>  
>> -			vsps = <&vspd0 0 &vspd1 0 &vspd0 1>;
>> +			vsps = <&vspd0 0>, <&vspd1 0>, <&vspd0 1>;
>>  
>>  			ports {
>>  				#address-cells = <1>;
>> diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
>> index 56cb566ffa09..79db5441b7e7 100644
>> --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
>> @@ -1764,7 +1764,7 @@
>>  			clocks = <&cpg CPG_MOD 724>,
>>  				 <&cpg CPG_MOD 723>;
>>  			clock-names = "du.0", "du.1";
>> -			vsps = <&vspd0 0 &vspd1 0>;
>> +			vsps = <&vspd0 0>, <&vspd1 0>;
>>  			status = "disabled";
>>  
>>  			ports {
>> diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
>> index 5bf3af246e14..49a11b4f55bd 100644
>> --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
>> @@ -1001,7 +1001,7 @@
>>  			clocks = <&cpg CPG_MOD 724>,
>>  				 <&cpg CPG_MOD 723>;
>>  			clock-names = "du.0", "du.1";
>> -			vsps = <&vspd0 0 &vspd1 0>;
>> +			vsps = <&vspd0 0>, <&vspd1 0>;
>>  			status = "disabled";
>>  
>>  			ports {
>