linux-kernel - Re: WARNING in kernfs_create_dir

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20190709142206.GI657710@devbig004.ftw2.facebook.com>
Date:   Tue, 9 Jul 2019 07:22:06 -0700
From:   Tejun Heo <tj@...nel.org>
To:     Hillf Danton <hdanton@...a.com>
Cc:     syzbot <syzbot+38f5d5cf7ae88c46b11a@...kaller.appspotmail.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "syzkaller-bugs@...glegroups.com" <syzkaller-bugs@...glegroups.com>
Subject: Re: WARNING in kernfs_create_dir_ns

On Tue, Jul 09, 2019 at 10:23:35AM +0800, Hillf Danton wrote:
> > I don't think this is the correct fix.  It's being called with kobj
> > whose parent's sysfs node is dangling.  It gotta be fixed from the
> > caller side.
> >
> Make sense?
> 
> --- a/lib/kobject.c
> +++ b/lib/kobject.c

No, I meant that the problem likely is in the driver which is calling
into the generic layer with a dead parent.  We shouldn't be working
around that from generic layer.

Thanks.

-- 
tejun