linux-kernel - Re: [PATCH] mm/kasan: fix kasan_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANpmjNNiygcPkXSFWGNZtOf6LC1Z_xjnim=4hH_KMDEZ9SodDg@mail.gmail.com>
Date:   Tue, 9 Jul 2019 20:46:20 +0200
From:   Marco Elver <elver@...gle.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Mark Rutland <mark.rutland@....com>,
        Andrey Ryabinin <aryabinin@...tuozzo.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Alexander Potapenko <glider@...gle.com>,
        Andrey Konovalov <andreyknvl@...gle.com>,
        Christoph Lameter <cl@...ux.com>,
        Pekka Enberg <penberg@...nel.org>,
        David Rientjes <rientjes@...gle.com>,
        Joonsoo Kim <iamjoonsoo.kim@....com>,
        Kees Cook <keescook@...omium.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Luc Van Oostenryck <luc.vanoostenryck@...il.com>,
        "ndesaulniers@...gle.com" <ndesaulniers@...gle.com>,
        Miguel Ojeda <miguel.ojeda.sandonis@...il.com>,
        Ingo Molnar <mingo@...nel.org>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm/kasan: fix kasan_check_read() compiler warning

On Tue, 9 Jul 2019 at 20:36, Arnd Bergmann <arnd@...db.de> wrote:
>
> The kasan_check_read() is marked 'inline', which usually includes
> the 'always_inline' attribute. In some configuration, gcc decides that
> it cannot inline this, causing a build failure:
>
> In file included from include/linux/compiler.h:257,
>                  from arch/x86/include/asm/current.h:5,
>                  from include/linux/sched.h:12,
>                  from include/linux/ratelimit.h:6,
>                  from fs/dcache.c:18:
> include/linux/compiler.h: In function 'read_word_at_a_time':
> include/linux/kasan-checks.h:31:20: error: inlining failed in call to always_inline 'kasan_check_read': function attribute mismatch
>  static inline bool kasan_check_read(const volatile void *p, unsigned int size)
>                     ^~~~~~~~~~~~~~~~
> In file included from arch/x86/include/asm/current.h:5,
>                  from include/linux/sched.h:12,
>                  from include/linux/ratelimit.h:6,
>                  from fs/dcache.c:18:
> include/linux/compiler.h:280:2: note: called from here
>   kasan_check_read(addr, 1);
>   ^~~~~~~~~~~~~~~~~~~~~~~~~
>
> While I have no idea why it does this, but changing the call to the
> internal __kasan_check_read() fixes the issue.

Thanks, this was fixed more generally in v5:
http://lkml.kernel.org/r/20190708170706.174189-1-elver@google.com

>
> Fixes: dc55b51f312c ("mm/kasan: introduce __kasan_check_{read,write}")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  include/linux/compiler.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/compiler.h b/include/linux/compiler.h
> index f0fd5636fddb..22909500ba1d 100644
> --- a/include/linux/compiler.h
> +++ b/include/linux/compiler.h
> @@ -277,7 +277,7 @@ static __always_inline void __write_once_size(volatile void *p, void *res, int s
>  static __no_kasan_or_inline
>  unsigned long read_word_at_a_time(const void *addr)
>  {
> -       kasan_check_read(addr, 1);
> +       __kasan_check_read(addr, 1);
>         return *(unsigned long *)addr;
>  }
>
> --
> 2.20.0
>