linux-kernel - Re: [PATCH net-next] net: dsa: vsc73xx: Fix Kconfig warning and build errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190709.142027.1850904278953075536.davem@davemloft.net>
Date:   Tue, 09 Jul 2019 14:20:27 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     yuehaibing@...wei.com
Cc:     andrew@...n.ch, vivien.didelot@...il.com, f.fainelli@...il.com,
        paweldembicki@...il.com, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: dsa: vsc73xx: Fix Kconfig warning and
 build errors

From: YueHaibing <yuehaibing@...wei.com>
Date: Tue, 9 Jul 2019 11:02:24 +0800

> Fix Kconfig dependency warning and subsequent build errors
> caused by OF is not set:
> 
> WARNING: unmet direct dependencies detected for NET_DSA_VITESSE_VSC73XX
>   Depends on [n]: NETDEVICES [=y] && HAVE_NET_DSA [=y] && OF [=n] && NET_DSA [=m]
>   Selected by [m]:
>   - NET_DSA_VITESSE_VSC73XX_PLATFORM [=m] && NETDEVICES [=y] && HAVE_NET_DSA [=y] && HAS_IOMEM [=y]
> 
> Make NET_DSA_VITESSE_VSC73XX_SPI and NET_DSA_VITESSE_VSC73XX_PLATFORM
> depends on NET_DSA_VITESSE_VSC73XX to fix this.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Suggested-by: Andrew Lunn <andrew@...n.ch>
> Fixes: 95711cd5f0b4 ("net: dsa: vsc73xx: Split vsc73xx driver")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
> v2: Use "depends on" instead of "select" NET_DSA_VITESSE_VSC73XX

I ended up applying Arnd's version of this fix which was very similar.

If there is anything you want to change just submit a relative patch
on top of Arnd's change.

Thank you.