linux-kernel - Re: [PATCH] ide: use BIT() macro for defining bit-flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190709.145241.634478641391763394.davem@davemloft.net>
Date:   Tue, 09 Jul 2019 14:52:41 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     suratiamol@...il.com
Cc:     linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH] ide: use BIT() macro for defining bit-flags

From: Amol Surati <suratiamol@...il.com>
Date: Sun, 7 Jul 2019 14:27:29 +0530

> The BIT() macro is available for defining the required bit-flags.
> 
> Since it operates on an unsigned value and expands to an unsigned result,
> using it, instead of an expression like (1 << x), also fixes the problem
> of shifting a signed 32-bit value by 31 bits (e.g. 1 << 31).
> 
> Signed-off-by: Amol Surati <suratiamol@...il.com>

Applied, thank you.