linux-kernel - Re: [PATCH -next] nfsd: Make two functions static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190709233646.GB1536@fieldses.org>
Date:   Tue, 9 Jul 2019 19:36:46 -0400
From:   "J. Bruce Fields" <bfields@...ldses.org>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     chuck.lever@...cle.com, linux-kernel@...r.kernel.org,
        linux-nfs@...r.kernel.org
Subject: Re: [PATCH -next] nfsd: Make two functions static

Thanks, applied.--b.

On Mon, Jul 08, 2019 at 03:29:33PM +0800, YueHaibing wrote:
> Fix sparse warnings:
> 
> fs/nfsd/nfs4state.c:1908:6: warning: symbol 'drop_client' was not declared. Should it be static?
> fs/nfsd/nfs4state.c:2518:6: warning: symbol 'force_expire_client' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  fs/nfsd/nfs4state.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index 94de5c3..7857942 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -1905,7 +1905,7 @@ static void __free_client(struct kref *k)
>  	kmem_cache_free(client_slab, clp);
>  }
>  
> -void drop_client(struct nfs4_client *clp)
> +static void drop_client(struct nfs4_client *clp)
>  {
>  	kref_put(&clp->cl_nfsdfs.cl_ref, __free_client);
>  }
> @@ -2515,7 +2515,7 @@ static const struct file_operations client_states_fops = {
>   * so the caller has a guarantee that the client's locks are gone by
>   * the time the write returns:
>   */
> -void force_expire_client(struct nfs4_client *clp)
> +static void force_expire_client(struct nfs4_client *clp)
>  {
>  	struct nfsd_net *nn = net_generic(clp->net, nfsd_net_id);
>  	bool already_expired;
> -- 
> 2.7.4
>