linux-kernel - [PATCH] hwmon (occ): Add temp sensor value check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190710072606.4849-1-joel@jms.id.au>
Date:   Wed, 10 Jul 2019 16:56:06 +0930
From:   Joel Stanley <joel@....id.au>
To:     Guenter Roeck <linux@...ck-us.net>, linux-hwmon@...r.kernel.org
Cc:     Eddie James <eajames@...ux.ibm.com>,
        Alexander Amelkin <a.amelkin@...ro.com>,
        Lei YU <mine260309@...il.com>,
        Alexander Soldatov <a.soldatov@...ro.com>,
        linux-kernel@...r.kernel.org
Subject: [PATCH] hwmon (occ): Add temp sensor value check

From: Alexander Soldatov <a.soldatov@...ro.com>

The occ driver supports two formats for the temp sensor value.

The OCC firmware for P8 supports only the first format, for which
no range checking or error processing is performed in the driver.
Inspecting the OCC sources for P8 reveals that OCC may send
a special value 0xFFFF to indicate that a sensor read timeout
has occurred, see

https://github.com/open-power/occ/blob/master_p8/src/occ/cmdh/cmdh_fsp_cmds.c#L395

That situation wasn't handled in the driver. This patch adds invalid
temp value check for the sensor data format 1 and handles it the same
way as it is done for the format 2, where EREMOTEIO is reported for
this case.

Fixes: 54076cb3b5ff ("hwmon (occ): Add sensor attributes and register hwmon device")
Signed-off-by: Alexander Soldatov <a.soldatov@...ro.com>
Signed-off-by: Alexander Amelkin <a.amelkin@...ro.com>
Reviewed-by: Alexander Amelkin <a.amelkin@...ro.com>
Reviewed-by: Eddie James <eajames@...ux.ibm.com>
Signed-off-by: Joel Stanley <joel@....id.au>
---
 drivers/hwmon/occ/common.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/hwmon/occ/common.c b/drivers/hwmon/occ/common.c
index cccf91742c1a..a7d2b16dd702 100644
--- a/drivers/hwmon/occ/common.c
+++ b/drivers/hwmon/occ/common.c
@@ -241,6 +241,12 @@ static ssize_t occ_show_temp_1(struct device *dev,
 		val = get_unaligned_be16(&temp->sensor_id);
 		break;
 	case 1:
+		/*
+		 * If a sensor reading has expired and couldn't be refreshed,
+		 * OCC returns 0xFFFF for that sensor.
+		 */
+		if (temp->value == 0xFFFF)
+			return -EREMOTEIO;
 		val = get_unaligned_be16(&temp->value) * 1000;
 		break;
 	default:
-- 
2.20.1