lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20190710072948.mpg4niors42zrqhc@verge.net.au>
Date:   Wed, 10 Jul 2019 09:29:48 +0200
From:   Simon Horman <horms@...ge.net.au>
To:     xianfengting221@....com, Pablo Neira Ayuso <pablo@...filter.org>
Cc:     wensong@...ux-vs.org, ja@....bg, pablo@...filter.org,
        kadlec@...ckhole.kfki.hu, fw@...len.de, davem@...emloft.net,
        netdev@...r.kernel.org, lvs-devel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipvs: Delete some unused space characters in Kconfig

On Sun, Jul 07, 2019 at 12:16:49PM +0800, xianfengting221@....com wrote:
> From: Hu Haowen <xianfengting221@....com>
> 
> The space characters at the end of lines are always unused and
> not easy to find. This patch deleted some of them I have found
> in Kconfig.
> 
> Signed-off-by: Hu Haowen <xianfengting221@....com>
> ---
> 
> This is my first patch to the Linux kernel, so please forgive
> me if anything went wrong.

Acked-by: Simon Horman <horms+renesas@...ge.net.au>

Thanks Hu,

this looks good to me.

Pablo, please consider this for inclusion in nf-next.

> 
>  net/netfilter/ipvs/Kconfig | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/net/netfilter/ipvs/Kconfig b/net/netfilter/ipvs/Kconfig
> index f6f1a0d..54afad5 100644
> --- a/net/netfilter/ipvs/Kconfig
> +++ b/net/netfilter/ipvs/Kconfig
> @@ -120,7 +120,7 @@ config	IP_VS_RR
>  
>  	  If you want to compile it in kernel, say Y. To compile it as a
>  	  module, choose M here. If unsure, say N.
> - 
> +
>  config	IP_VS_WRR
>  	tristate "weighted round-robin scheduling"
>  	---help---
> @@ -138,7 +138,7 @@ config	IP_VS_LC
>          tristate "least-connection scheduling"
>  	---help---
>  	  The least-connection scheduling algorithm directs network
> -	  connections to the server with the least number of active 
> +	  connections to the server with the least number of active
>  	  connections.
>  
>  	  If you want to compile it in kernel, say Y. To compile it as a
> @@ -193,7 +193,7 @@ config  IP_VS_LBLCR
>  	tristate "locality-based least-connection with replication scheduling"
>  	---help---
>  	  The locality-based least-connection with replication scheduling
> -	  algorithm is also for destination IP load balancing. It is 
> +	  algorithm is also for destination IP load balancing. It is
>  	  usually used in cache cluster. It differs from the LBLC scheduling
>  	  as follows: the load balancer maintains mappings from a target
>  	  to a set of server nodes that can serve the target. Requests for
> @@ -250,8 +250,8 @@ config	IP_VS_SED
>  	tristate "shortest expected delay scheduling"
>  	---help---
>  	  The shortest expected delay scheduling algorithm assigns network
> -	  connections to the server with the shortest expected delay. The 
> -	  expected delay that the job will experience is (Ci + 1) / Ui if 
> +	  connections to the server with the shortest expected delay. The
> +	  expected delay that the job will experience is (Ci + 1) / Ui if
>  	  sent to the ith server, in which Ci is the number of connections
>  	  on the ith server and Ui is the fixed service rate (weight)
>  	  of the ith server.
> -- 
> 2.7.4
> 
> 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ