[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2a6f5cc2-40cb-647c-003d-aae594d05062@virtuozzo.com>
Date: Wed, 10 Jul 2019 09:24:32 +0000
From: Konstantin Khorenko <khorenko@...tuozzo.com>
To: Finn Thain <fthain@...egraphics.com.au>,
"Andrey Jr. Melnikov" <temnota.am@...il.com>,
Raghava Aditya Renukunta
<RaghavaAditya.Renukunta@...rosemi.com>
CC: "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] scsi: aacraid: resurrect correct arc ctrl checks for
Series-6
On 07/08/2019 02:49 AM, Finn Thain wrote:
> Andrey,
>
> It is helpful to send your review to the patch author. I've added
> Konstantin to the Cc list, as well as Raghava (who introduced the
> regression addressed by Konstantin's patch).
>
> If I'm not mistaken, your review misunderstands the patch description.
>
> FWIW, Konstantin's patch might have been easier to follow if it was a
> simple 'git revert'.
Hi Finn, Andrey,
Finn,
thank you for putting me back to the thread, appreciated.
And i agree with you, may be git revert followed by independent patch
which removes Series-9 mentions is easier to read, so sending the second
version - in that way.
Andrey,
please take a look at the new version patches, hope it's easier to understand.
And talking about the helper: i thought about leaving it, but we have several places which check for Series 7 and 8 only
and several places which check for Series 6,7,8, so either
- we need 2 helpers
- we have a helper to check for Series 7,8 only and in some places will have a check for Series 6 + helper
- introduce the helper with parameter
Honestly i don't like any of variants above, so just left the code without helper,
not that many checks and easier to read the code IMHO.
Thank you!
--
Best regards,
Konstantin Khorenko,
Virtuozzo Linux Kernel Team
Powered by blists - more mailing lists