[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190710093139.GG7034@mtr-leonro.mtl.com>
Date: Wed, 10 Jul 2019 12:31:39 +0300
From: Leon Romanovsky <leon@...nel.org>
To: Nathan Chancellor <natechancellor@...il.com>
Cc: Saeed Mahameed <saeedm@...lanox.com>,
"David S. Miller" <davem@...emloft.net>,
Boris Pismenny <borisp@...lanox.com>, netdev@...r.kernel.org,
linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
clang-built-linux@...glegroups.com,
Nick Desaulniers <ndesaulniers@...gle.com>
Subject: Re: [PATCH net-next v3] net/mlx5e: Convert single case statement
switch statements into if statements
On Tue, Jul 09, 2019 at 11:06:15PM -0700, Nathan Chancellor wrote:
> During the review of commit 1ff2f0fa450e ("net/mlx5e: Return in default
> case statement in tx_post_resync_params"), Leon and Nick pointed out
> that the switch statements can be converted to single if statements
> that return early so that the code is easier to follow.
>
> Suggested-by: Leon Romanovsky <leon@...nel.org>
> Suggested-by: Nick Desaulniers <ndesaulniers@...gle.com>
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>
> ---
Thanks again,
Reviewed-by: Leon Romanovsky <leonro@...lanox.com>
Powered by blists - more mailing lists