linux-kernel - Re: [PATCH] sound: pci: lx6464es: Remove unneeded variable err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hh87urzbf.wl-tiwai@suse.de>
Date:   Wed, 10 Jul 2019 11:52:52 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     "Hariprasad Kelam" <hariprasad.kelam@...il.com>
Cc:     <alsa-devel@...a-project.org>,
        "Thomas Gleixner" <tglx@...utronix.de>,
        "Kate Stewart" <kstewart@...uxfoundation.org>,
        "Allison Randal" <allison@...utok.net>,
        "Jaroslav Kysela" <perex@...ex.cz>,
        "Takashi Iwai" <tiwai@...e.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sound: pci: lx6464es: Remove unneeded variable err

On Wed, 10 Jul 2019 11:49:31 +0200,
Takashi Iwai wrote:
> 
> On Wed, 10 Jul 2019 04:30:59 +0200,
> Hariprasad Kelam wrote:
> > 
> > This patch fixes below issue reported by coccicheck
> > sound/pci/lx6464es/lx6464es.c:256:5-8: Unneeded variable: "err". Return
> > "0" on line 258
> > 
> > We cannot change return value as its registered with snd_pcm_ops->close
> > 
> > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@...il.com>
> 
> Applied, thanks.

Well, looking at the description above again, I'd drop the text

 "We cannot change return value as its registered with
  snd_pcm_ops->close"

because this is quite misleading.  There is absolutely no need for
changing the function return type.


thanks,

Takashi