lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 10 Jul 2019 14:03:40 +0200 From: Florian Eckert <fe@....tdt.de> To: "Enrico Weigelt, metux IT consult" <lkml@...ux.net> Cc: Eckert.Florian@...glemail.com, info@...ux.net, dvhart@...radead.org, andy@...radead.org, platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/3] platform/x86/pcengines-apuv2: add legacy leds gpio definitions On 2019-07-08 21:42, Enrico Weigelt, metux IT consult wrote: > On 04.07.19 11:02, Florian Eckert wrote: >> Extend the apu2_leds definition to make the leds exportable via the >> legacy gpio subsystem. > > What for ? The gpios are bound to LED devices as that's exactly what > they are: LEDs. I have back ported your pcengines-apuv2 device and gpio-amd-fch GPIO driver to the kernel version 4.19 on OpenWrt. If I compile and load this without the change no LEDs are visible in "/sys/class/leds"! From my point of view the connection between the GPIO and the LEDs subsystem is missing. How should the LED subsystem know which GPIO to use? If I add the change to the pcengines-apuv2 device then the LEDs will be visilbe under "/sys/class/leds" and could be used, by OpenWrt userland. Mybe I miss something.
Powered by blists - more mailing lists