linux-kernel - Re: [PATCH 0/3] Update pcengines-apuv2 platform device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 10 Jul 2019 14:54:03 +0200
From:   Florian Eckert <fe@....tdt.de>
To:     "Enrico Weigelt, metux IT consult" <lkml@...ux.net>
Cc:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Eckert.Florian@...glemail.com,
        "Enrico Weigelt, metux IT consult" <info@...ux.net>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/3] Update pcengines-apuv2 platform device

On 2019-07-08 21:45, Enrico Weigelt, metux IT consult wrote:
> On 04.07.19 15:39, Andy Shevchenko wrote:
>> On Thu, Jul 4, 2019 at 12:02 PM Florian Eckert <fe@....tdt.de> wrote:
>>> 
>>> This patchset adds the following changes to this pcengines-apuv2
>>> platform device.
>>> 
>> 
>> Before doing anything to this driver, what is the plan for previously
>> upstreamed:
>> 
>> drivers/leds/leds-apu.c
> 
> Only supports the three front LEDs, nothing else. (we've got more gpios
> that are not LEDs, eg. the front button, simsw, ...)
> 
>> arch/x86/platform/geode/alix.c
> 
> completely unrelated - very different chipset.
> 
> 
> --mtx

I'm going to sum it all what we have

ALIX family boards (https://www.pcengines.ch/alix.htm):
CPU -> AMD Geode LX CPU
Stays as it is different because it has a different CPU

APU family boards (https://www.pcengines.ch/apu.htm):
CPU -> AMD G series T40E APU
Remove the related APU2 family stuff from the LEDs driver
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/leds/leds-apu.c
this will be handled in the future by the platform device
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/platform/x86/pcengines-apuv2.c
The other GPIOs are not supported by this platform. Only LEDs are 
supported for now.

APU2 family boards (https://www.pcengines.ch/apu2.htm):
CPU -> AMD Embedded G series GX-412TC
Add the additional mpcie reset pins and add additional board 
descriptions to
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/platform/x86/pcengines-apuv2.c?h=v5.2#n61
so we can distinguish between the APU2,APU3 and APU4 boards of the APU2 
board family.

My research in the pcengines documentation shows the following GPIO pins 
for the individual boards which we can support.

APU2:
front-led1
front-led2
front-led3
front-button
mpcie2_reset
mpcie3_reset

APU3:
front-led1
front-led2
front-led3
front-button
mpcie2_reset
mpcie3_reset
simswap

APU4:
front-led1
front-led2
front-led3
front-button
mpcie2_reset
mpcie3_reset

Until now we support aAPU2 and APU3 and treat it the same way. But the 
APU2 does not have a simswap.

Kind regards

Florian