linux-kernel - Re: [PATCH] drm/msm/a6xx: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAF6AEGsGbOOssmTB0WUJUPJRkhvhwLpe81fYVa0PSXLPKDSLZQ@mail.gmail.com>
Date:   Wed, 10 Jul 2019 09:05:08 -0700
From:   Rob Clark <robdclark@...il.com>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     dri-devel <dri-devel@...ts.freedesktop.org>,
        Rob Clark <robdclark@...omium.org>,
        Sean Paul <sean@...rly.run>, David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Jordan Crouse <jcrouse@...eaurora.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        freedreno <freedreno@...ts.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/msm/a6xx: add missing MODULE_FIRMWARE()

On Mon, Jul 8, 2019 at 11:18 AM Bjorn Andersson
<bjorn.andersson@...aro.org> wrote:
>
> On Wed 03 Jul 07:00 PDT 2019, Rob Clark wrote:
>
> > From: Rob Clark <robdclark@...omium.org>
> >
> > For platforms that require the "zap shader" to take the GPU out of
> > secure mode at boot, we also need the zap fw to end up in the initrd.
> >
> > Signed-off-by: Rob Clark <robdclark@...omium.org>
>
> My upcoming pull request for this merge window includes the support for
> the mdt_loader to read unsplit firmware files. So how about running the
> firmware through [1] (pil-squasher a630_zap.mbn a630_zap.mdt) and
> pointing the driver to use the single .mbn file instead?
>

I wonder if it would just make sense to list both, at least until we
change the a6xx code to *require* zap fw if the zap node in dt isn't
removed (since the outcome of gpu driver assuming missing zap fw means
zap is not required is slightly brutal)

BR,
-R

>
> If not, you have my:
> Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>
>
> [1] https://github.com/andersson/pil-squasher
>