[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20190710122018.2250-1-iamkeyur96@gmail.com>
Date: Wed, 10 Jul 2019 08:20:17 -0400
From: Keyur Patel <iamkeyur96@...il.com>
To: unlisted-recipients:; (no To-header on input)
Cc: iamkeyur96@...il.com, David Lin <dtwlin@...il.com>,
Johan Hovold <johan@...nel.org>, Alex Elder <elder@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
greybus-dev@...ts.linaro.org, devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH] staging: greybus: add logging statement when kfifo_alloc fails
Added missing logging statement when kfifo_alloc fails, to improve
debugging.
Signed-off-by: Keyur Patel <iamkeyur96@...il.com>
---
drivers/staging/greybus/uart.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c
index b3bffe91ae99..86a395ae177d 100644
--- a/drivers/staging/greybus/uart.c
+++ b/drivers/staging/greybus/uart.c
@@ -856,8 +856,10 @@ static int gb_uart_probe(struct gbphy_device *gbphy_dev,
retval = kfifo_alloc(&gb_tty->write_fifo, GB_UART_WRITE_FIFO_SIZE,
GFP_KERNEL);
- if (retval)
+ if (retval) {
+ pr_err("kfifo_alloc failed\n");
goto exit_buf_free;
+ }
gb_tty->credits = GB_UART_FIRMWARE_CREDITS;
init_completion(&gb_tty->credits_complete);
--
2.22.0
Powered by blists - more mailing lists