linux-kernel - Re: [PATCH] [net-next] IB/hfi1: removed shadowed 'err' variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190710165812.GK2887@mellanox.com>
Date:   Wed, 10 Jul 2019 16:58:16 +0000
From:   Jason Gunthorpe <jgg@...lanox.com>
To:     "Marciniszyn, Mike" <mike.marciniszyn@...el.com>
CC:     Arnd Bergmann <arnd@...db.de>,
        "Dalessandro, Dennis" <dennis.dalessandro@...el.com>,
        Doug Ledford <dledford@...hat.com>,
        "Arumugam, Kamenee" <kamenee.arumugam@...el.com>,
        Shamir Rabinovitch <shamir.rabinovitch@...cle.com>,
        Gal Pressman <galpress@...zon.com>,
        Leon Romanovsky <leon@...nel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "clang-built-linux@...glegroups.com" 
        <clang-built-linux@...glegroups.com>
Subject: Re: [PATCH] [net-next] IB/hfi1: removed shadowed 'err' variable

On Wed, Jul 10, 2019 at 04:54:33PM +0000, Marciniszyn, Mike wrote:
> > Subject: [PATCH] [net-next] IB/hfi1: removed shadowed 'err' variable
> > 
> > I can't think of any reason for the inner variable declaration, so
> > remove it to avoid the issue.
> > 
> 
> I agree!
> 
> > Fixes: 239b0e52d8aa ("IB/hfi1: Move rvt_cq_wc struct into uapi directory")
> 
> Thanks for catching this!
> 
> Acked-by: Mike Marciniszyn <mike.marciniszyn@...el.com>

Thanks, I'm going to take Nathan's identical patch though, it arrived
first

Jason