linux-kernel - Re: [PATCH] rdma/siw: Use proper enumerated type in map_cqe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190710182624.GG4051@ziepe.ca>
Date:   Wed, 10 Jul 2019 15:26:24 -0300
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     Nathan Chancellor <natechancellor@...il.com>
Cc:     Bernard Metzler <bmt@...ich.ibm.com>,
        Doug Ledford <dledford@...hat.com>, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org, clang-built-linux@...glegroups.com
Subject: Re: [PATCH] rdma/siw: Use proper enumerated type in map_cqe_status

On Wed, Jul 10, 2019 at 10:48:00AM -0700, Nathan Chancellor wrote:
> clang warns several times:
> 
> drivers/infiniband/sw/siw/siw_cq.c:31:4: warning: implicit conversion
> from enumeration type 'enum siw_wc_status' to different enumeration type
> 'enum siw_opcode' [-Wenum-conversion]
>         { SIW_WC_SUCCESS, IB_WC_SUCCESS },
>         ~ ^~~~~~~~~~~~~~
> 
> Fixes: b0fff7317bb4 ("rdma/siw: completion queue methods")
> Link: https://github.com/ClangBuiltLinux/linux/issues/596
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>
> ---
>  drivers/infiniband/sw/siw/siw_cq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Weird that gcc doesn't warn on this by default..

Applied to for-next, thanks

Jason