[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190710190949.GA22995@amd>
Date: Wed, 10 Jul 2019 21:09:50 +0200
From: Pavel Machek <pavel@....cz>
To: Jean-Jacques Hiblot <jjhiblot@...com>
Cc: jacek.anaszewski@...il.com, robh+dt@...nel.org,
mark.rutland@....com, lee.jones@...aro.org,
daniel.thompson@...aro.org, jingoohan1@...il.com, dmurphy@...com,
linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org,
dri-devel@...ts.freedesktop.org, tomi.valkeinen@...com
Subject: Re: [PATCH v3 1/4] leds: Add of_led_get() and led_put()
On Wed 2019-07-10 14:39:29, Jean-Jacques Hiblot wrote:
> From: Tomi Valkeinen <tomi.valkeinen@...com>
>
> This patch adds basic support for a kernel driver to get a LED device.
> This will be used by the led-backlight driver.
>
> Only OF version is implemented for now, and the behavior is similar to
> PWM's of_pwm_get() and pwm_put().
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@...com>
> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@...com>
> @@ -214,6 +215,55 @@ static int led_resume(struct device *dev)
>
> static SIMPLE_DEV_PM_OPS(leds_class_dev_pm_ops, led_suspend, led_resume);
>
> +static int led_match_led_node(struct device *led_dev, const void *data)
> +{
> + return led_dev->of_node == data ? 1 : 0;
> +}
Get rid of the "? 1 : 0"?
> + led_node = of_parse_phandle(np, "leds", index);
> + if (!led_node)
> + return ERR_PTR(-ENOENT);
> + led_dev = class_find_device(leds_class, NULL, led_node,
> + led_match_led_node);
> + of_node_put(led_node);
> +
> + if (!led_dev)
> + return ERR_PTR(-EPROBE_DEFER);
Won't this defer probe "forever" when the driver is not available?
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)
Powered by blists - more mailing lists