linux-kernel - Re: sched_clock and device suspend/resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190710151334.49158be3@gandalf.local.home>
Date:   Wed, 10 Jul 2019 15:13:34 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     Sodagudi Prasad <psodagud@...eaurora.org>,
        gregkh@...uxfoundation.org, john.stultz@...aro.org,
        chang-an.chen@...iatek.com, mingo@...nel.org, pmladek@...e.com,
        sergey.senozhatsky@...il.com, linux-kernel@...r.kernel.org,
        tsoni@...eaurora.org
Subject: Re: sched_clock and device suspend/resume


[ Removed the two emails that were bouncing ]

On Wed, 10 Jul 2019 21:06:57 +0200 (CEST)
Thomas Gleixner <tglx@...utronix.de> wrote:

> > > > sched_clock_continuous() ? (I know, horrible name), that simply keeps
> > > > track of the time delta at suspend and returns:
> > > > 
> > > > 	sched_clock() + delta;    
> > > 
> > > Which you get already when you do
> > > 
> > > # echo boot > /sys/kernel/debug/tracing/trace_clock
> > >   
> > 
> > So basically the answer here is to change printk to use
> > ktime_get_boot_fast_ns() instead of local_clock()?  
> 
> Aargh. That was tracing.
> 
> There was a patchset floating around which actually implemented that clock
> choice for sched_clock as well. Don't know why that was never merged.

Will it cause issues with the scheduler though. If it doesn't stop
during suspend, can't that make the scheduler think that processes were
using the CPU during the entire suspend and screw up the accounting?

-- Steve