linux-kernel - Re: BUG: MAX_STACK_TRACE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 10 Jul 2019 22:47:43 +0200
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Bart Van Assche <bvanassche@....org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>, Will Deacon <will@...nel.org>,
        linux-kernel@...r.kernel.org,
        syzbot <syzbot+6f39a9deb697359fe520@...kaller.appspotmail.com>,
        syzkaller-bugs@...glegroups.com
Subject: Re: BUG: MAX_STACK_TRACE_ENTRIES too low! (2)



On 7/10/19 9:09 PM, Bart Van Assche wrote:
> On 7/10/19 11:44 AM, Eric Dumazet wrote:
>> If anything using workqueues in dynamically allocated objects can turn off lockdep,
>> we have a serious issue.
> 
> As far as I know that issue is only hit by syzbot tests.



> Anyway, I see
> two possible paths forward:
> * Revert the patch that makes workqueues use dynamic lockdep keys and
> thereby reintroduce the false positives that lockdep reports if
> different workqueues share a lockdep key. I think there is agreement
> that having to analyze lockdep false positives is annoying, time
> consuming and something nobody likes.
> * Modify lockdep such that space in its fixed size arrays that is no
> longer in use gets reused. Since the stack traces saved in the
> stack_trace[] array have a variable size that array will have to be
> compacted to avoid fragmentation.
> 

Can not destroy_workqueue() undo what alloc_workqueue() did ?