linux-kernel - Re: [PATCH] Staging: rtl8723bs: hal: rtl8723bs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bc0f21dd8753190c6fbba0d3f7469a2d8c87b341.camel@perches.com>
Date:   Wed, 10 Jul 2019 15:30:32 -0700
From:   Joe Perches <joe@...ches.com>
To:     Fatih ALTINPINAR <fatihaltinpinar@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Hariprasad Kelam <hariprasad.kelam@...il.com>,
        Himadri Pandya <himadri18.07@...il.com>,
        Josenivaldo Benito Jr <jrbenito@...ito.qsl.br>,
        Larry Finger <Larry.Finger@...inger.net>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: rtl8723bs: hal: rtl8723bs_recv.c: Fix code
 style

On Mon, 2019-07-08 at 12:56 +0300, Fatih ALTINPINAR wrote:
> Fixed a coding stlye issue. Removed braces from a single statement if
> block.
> 
> Signed-off-by: Fatih ALTINPINAR <fatihaltinpinar@...il.com>
> ---
>  drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c
> index e23b39ab16c5..71a4bcbeada9 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c
> @@ -449,9 +449,8 @@ s32 rtl8723bs_init_recv_priv(struct adapter *padapter)
>  				skb_reserve(precvbuf->pskb, (RECVBUFF_ALIGN_SZ - alignment));
>  			}
>  
> -			if (!precvbuf->pskb) {
> +			if (!precvbuf->pskb)
>  				DBG_871X("%s: alloc_skb fail!\n", __func__);
> -			}

You could delete the block instead.
alloc_skb failures already do a dump_stack()