linux-kernel - Re: [PATCH 2/2] Fixed a brace styling issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <38EEDC9B-0C4F-4207-BD71-C03E5FC7DE51@holtmann.org>
Date:   Thu, 11 Jul 2019 09:03:42 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     sheetalsingala <2396sheetal@...il.com>
Cc:     marcel@...tman.org,
        Linux Bluetooth mailing list 
        <linux-bluetooth@...r.kernel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] Fixed a brace styling issue

Hi,

> Fixed a coding style issue
> 
> Signed-off-by: Sheetal Singala <2396sheetal@...il.com>
> ---
> drivers/bluetooth/btintel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
> index bb99c8653aab..4a8b812605f3 100644
> --- a/drivers/bluetooth/btintel.c
> +++ b/drivers/bluetooth/btintel.c
> @@ -18,7 +18,7 @@
> 
> #define VERSION "0.1"
> 
> -#define BDADDR_INTEL (&(bdaddr_t) {{0x00, 0x8b, 0x9e, 0x19, 0x03, 0x00}})
> +#define BDADDR_INTEL (&(bdaddr_t) {0x00, 0x8b, 0x9e, 0x19, 0x03, 0x00})

maybe you want to test your patches before sending them.

  CC      drivers/bluetooth/btintel.o
drivers/bluetooth/btintel.c: In function ‘btintel_check_bdaddr’:
drivers/bluetooth/btintel.c:21:24: warning: missing braces around initializer [-Wmissing-braces]
   21 | #define BDADDR_INTEL (&(bdaddr_t) {0x00, 0x8b, 0x9e, 0x19, 0x03, 0x00})
      |                        ^
drivers/bluetooth/btintel.c:50:27: note: in expansion of macro ‘BDADDR_INTEL’
   50 |  if (!bacmp(&bda->bdaddr, BDADDR_INTEL)) {
      |                           ^~~~~~~~~~~~

Regards

Marcel