linux-kernel - Re: [PATCH] watchdog: digicolor_wdt: remove unused variable 'ret'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <874l3tow2c.fsf@tarshish>
Date:   Thu, 11 Jul 2019 10:43:39 +0300
From:   Baruch Siach <baruch@...s.co.il>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     wim@...ux-watchdog.org, linux@...ck-us.net,
        wsa+renesas@...g-engineering.com, linux-kernel@...r.kernel.org,
        linux-watchdog@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] watchdog: digicolor_wdt: remove unused variable 'ret'

Hi YueHaibing,

On Thu, Jul 11 2019, YueHaibing wrote:
> commit cdad26977e3f ("watchdog: digicolor_wdt: drop
> warning after registering device") left this unused
> variable, it can be removed.
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Third time's a charm:

https://patchwork.kernel.org/patch/11037487/
https://patchwork.kernel.org/patch/11038317/

baruch

>  drivers/watchdog/digicolor_wdt.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/watchdog/digicolor_wdt.c b/drivers/watchdog/digicolor_wdt.c
> index 33cda95..073d378 100644
> --- a/drivers/watchdog/digicolor_wdt.c
> +++ b/drivers/watchdog/digicolor_wdt.c
> @@ -118,7 +118,6 @@ static int dc_wdt_probe(struct platform_device *pdev)
>  {
>  	struct device *dev = &pdev->dev;
>  	struct dc_wdt *wdt;
> -	int ret;
>  
>  	wdt = devm_kzalloc(dev, sizeof(struct dc_wdt), GFP_KERNEL);
>  	if (!wdt)

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@...s.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -