linux-kernel - Re: [PATCH -next] rdma/siw: remove set but not used variable 's'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <OF7C58670D.824A65B3-ON00258434.002DF9B8-00258434.002DF9C1@notes.na.collabserv.com>
Date:   Thu, 11 Jul 2019 08:22:10 +0000
From:   "Bernard Metzler" <BMT@...ich.ibm.com>
To:     "YueHaibing" <yuehaibing@...wei.com>
Cc:     <dledford@...hat.com>, <jgg@...pe.ca>,
        <linux-kernel@...r.kernel.org>, <linux-rdma@...r.kernel.org>
Subject: Re:  [PATCH -next] rdma/siw: remove set but not used variable 's'

-----"YueHaibing" <yuehaibing@...wei.com> wrote: -----

>To: <bmt@...ich.ibm.com>, <dledford@...hat.com>, <jgg@...pe.ca>
>From: "YueHaibing" <yuehaibing@...wei.com>
>Date: 07/11/2019 09:13AM
>Cc: <linux-kernel@...r.kernel.org>, <linux-rdma@...r.kernel.org>,
>"YueHaibing" <yuehaibing@...wei.com>
>Subject: [EXTERNAL] [PATCH -next] rdma/siw: remove set but not used
>variable 's'
>
>Fixes gcc '-Wunused-but-set-variable' warning:
>
>drivers/infiniband/sw/siw/siw_cm.c: In function
>siw_cm_llp_state_change:
>drivers/infiniband/sw/siw/siw_cm.c:1278:17: warning: variable s set
>but not used [-Wunused-but-set-variable]
>
>Reported-by: Hulk Robot <hulkci@...wei.com>
>Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>---
> drivers/infiniband/sw/siw/siw_cm.c | 3 ---
> 1 file changed, 3 deletions(-)
>
>diff --git a/drivers/infiniband/sw/siw/siw_cm.c
>b/drivers/infiniband/sw/siw/siw_cm.c
>index c883bf5..7d87a78 100644
>--- a/drivers/infiniband/sw/siw/siw_cm.c
>+++ b/drivers/infiniband/sw/siw/siw_cm.c
>@@ -1275,7 +1275,6 @@ static void siw_cm_llp_error_report(struct sock
>*sk)
> static void siw_cm_llp_state_change(struct sock *sk)
> {
> 	struct siw_cep *cep;
>-	struct socket *s;
> 	void (*orig_state_change)(struct sock *s);
> 
> 	read_lock(&sk->sk_callback_lock);
>@@ -1288,8 +1287,6 @@ static void siw_cm_llp_state_change(struct sock
>*sk)
> 	}
> 	orig_state_change = cep->sk_state_change;
> 
>-	s = sk->sk_socket;
>-
> 	siw_dbg_cep(cep, "state: %d\n", cep->state);
> 
> 	switch (sk->sk_state) {
>-- 
>2.7.4
>
>
>

Another bad leftover from excessive debugging times...

Thanks alot Yue!
Bernard.