linux-kernel - Re: [PATCH v2 4/6] ASoC: sgtl5000: Fix charge pump source assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAByghJYJDTiq=3Y8njfvmnnE6rqnEjjDukrJY=pbH8gcDEoxQA@mail.gmail.com>
Date:   Thu, 11 Jul 2019 10:21:00 +0000
From:   Igor Opaniuk <igor.opaniuk@...adex.com>
To:     Oleksandr Suvorov <oleksandr.suvorov@...adex.com>
CC:     Fabio Estevam <festevam@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        Marcel Ziswiler <marcel.ziswiler@...adex.com>,
        Igor Opaniuk <igor.opaniuk@...adex.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Mark Brown <broonie@...nel.org>, Takashi Iwai <tiwai@...e.com>,
        Liam Girdwood <lgirdwood@...il.com>
Subject: Re: [PATCH v2 4/6] ASoC: sgtl5000: Fix charge pump source assignment

Hi Oleksandr,

On Tue, Jun 25, 2019 at 10:56 AM Oleksandr Suvorov
<oleksandr.suvorov@...adex.com> wrote:
>
> If VDDA != VDDIO and any of them is greater than 3.1V, charge pump
> source can be assigned automatically.
minor: Could also you please add a reference link to the commit message,
where this behavior is defined?

>
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@...adex.com>
> ---
>
>  sound/soc/codecs/sgtl5000.c | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c
> index e813a37910af4..ee1e4bf613227 100644
> --- a/sound/soc/codecs/sgtl5000.c
> +++ b/sound/soc/codecs/sgtl5000.c
> @@ -1174,12 +1174,16 @@ static int sgtl5000_set_power_regs(struct snd_soc_component *component)
>                                         SGTL5000_INT_OSC_EN);
>                 /* Enable VDDC charge pump */
>                 ana_pwr |= SGTL5000_VDDC_CHRGPMP_POWERUP;
> -       } else if (vddio >= 3100 && vdda >= 3100) {
> +       } else {
>                 ana_pwr &= ~SGTL5000_VDDC_CHRGPMP_POWERUP;
> -               /* VDDC use VDDIO rail */
> -               lreg_ctrl |= SGTL5000_VDDC_ASSN_OVRD;
> -               lreg_ctrl |= SGTL5000_VDDC_MAN_ASSN_VDDIO <<
> -                           SGTL5000_VDDC_MAN_ASSN_SHIFT;
> +               /* if vddio == vdda the source of charge pump should be
> +                * assigned manually to VDDIO
> +                */
minor: please check the preferred style for long (multi-line) comments
in coding-style.rst,
first line should be empty.

> +               if (vddio == vdda) {
> +                       lreg_ctrl |= SGTL5000_VDDC_ASSN_OVRD;
> +                       lreg_ctrl |= SGTL5000_VDDC_MAN_ASSN_VDDIO <<
> +                                   SGTL5000_VDDC_MAN_ASSN_SHIFT;
> +               }
>         }
>
>         snd_soc_component_write(component, SGTL5000_CHIP_LINREG_CTRL, lreg_ctrl);
> --
> 2.20.1
>

With my comments addressed:
Reviewed-by: Igor Opaniuk <igor.opaniuk@...adex.com>

-- 
Best regards - Freundliche Grüsse - Meilleures salutations

Senior Development Engineer,
Igor Opaniuk

Toradex AG
Altsagenstrasse 5 | 6048 Horw/Luzern | Switzerland | T: +41 41 500 48
00 (main line)