linux-kernel - Re: [PATCH v2] KVM: x86: PMU Event Filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <21fd772c-2267-2122-c878-f80185d8ca86@redhat.com>
Date:   Thu, 11 Jul 2019 13:58:04 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Eric Hankland <ehankland@...gle.com>,
        Wei Wang <wei.w.wang@...el.com>, rkrcmar@...hat.com
Cc:     linux-kernel@...r.kernel.org,
        Stephane Eranian <eranian@...gle.com>, kvm@...r.kernel.org
Subject: Re: [PATCH v2] KVM: x86: PMU Event Filter

On 11/07/19 03:25, Eric Hankland wrote:
> - Add a VM ioctl that can control which events the guest can monitor.

... and finally:

- the patch whitespace is damaged

- the filter is leaked when the VM is destroyed

- kmalloc(GFP_KERNEL_ACCOUNT) is preferrable to vmalloc because it
accounts memory to the VM correctly.

Since this is your first submission, I have fixed up everything.

Paolo