linux-kernel - Re: [GIT PULL] clone3 for v5.3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190711134552.jvahfwhvaxykbgfl@brauner.io>
Date:   Thu, 11 Jul 2019 15:45:53 +0200
From:   Christian Brauner <christian@...uner.io>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Linux List Kernel Mailing <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] clone3 for v5.3

On Thu, Jul 11, 2019 at 07:34:28AM +0200, Christian Brauner wrote:
> On Wed, Jul 10, 2019 at 10:24:26PM -0700, Linus Torvalds wrote:
> > On Mon, Jul 8, 2019 at 8:05 AM Christian Brauner <christian@...uner.io> wrote:
> > >
> > > /* Syscall number 435 */
> > > clone3() uses syscall number 435 and is coordinated with pidfd_open() which
> > > uses syscall number 434. I'm not aware of any other syscall targeted for
> > > 5.3 that has chosen the same number.
> > 
> > You say that, and 434/435 would make sense, but that's not what the
> > code I see in the pull request actually does.
> > 
> > It seems to use syscall 436.
> > 
> > I think it's because openat2() is looking to use 435, but I'm a bit
> > nervous about the conflict between the code and your commentary..
> 
> Sorry, that was just me being dumb and forgetting that there was
> close_range() which had a chance of going through Al's tree. So I left a
> hole for it.
> 
> I don't terribly mind if it's 435 or 436. People pointed out you might
> even renumber yourself if something makes more sense to you.

Just in case you prefer pulling from a __rebased__ tree. I prepared one.
It does use syscall number 435 as advertised here and has the merge
conflict I pointed out in the PR resolved:

The following changes since commit 5450e8a316a64cddcbc15f90733ebc78aa736545:

  Merge tag 'pidfd-updates-v5.3' of git://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux (2019-07-10 22:17:21 -0700)

are available in the Git repository at:

  git@...olite.kernel.org:pub/scm/linux/kernel/git/brauner/linux tags/clone3-rebased-v5.3

for you to fetch changes up to 611e04b559151c441deedc79f1e57471c953bda7:

  arch: handle arches who do not yet define clone3 (2019-07-11 14:59:15 +0200)

Christian