linux-kernel - Re: [PATCH] s390/zcrypt: remove the exporting of ap_query

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 11 Jul 2019 15:52:48 +0200
From:   Vasily Gorbik <gor@...ux.ibm.com>
To:     Harald Freudenberger <freude@...ux.ibm.com>
Cc:     Denis Efremov <efremov@...ux.com>,
        Heiko Carstens <heiko.carstens@...ibm.com>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] s390/zcrypt: remove the exporting of
 ap_query_configuration

On Wed, Jul 10, 2019 at 08:44:53AM +0200, Harald Freudenberger wrote:
> On 09.07.19 14:25, Denis Efremov wrote:
> > The function ap_query_configuration is declared static and marked
> > EXPORT_SYMBOL, which is at best an odd combination. Because the
> > function is not used outside of the drivers/s390/crypto/ap_bus.c
> > file it is defined in, this commit removes the EXPORT_SYMBOL() marking.
> >
> > Fixes: f1b0a4343c41 ("s390/zcrypt: Integrate ap_asm.h into include/asm/ap.h.")
> > Fixes: 050349b5b71d ("s390/zcrypt: externalize AP config info query")
> > Signed-off-by: Denis Efremov <efremov@...ux.com>
> > ---
> >  drivers/s390/crypto/ap_bus.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/s390/crypto/ap_bus.c b/drivers/s390/crypto/ap_bus.c
> > index b9fc502c58c2..379e43b79006 100644
> > --- a/drivers/s390/crypto/ap_bus.c
> > +++ b/drivers/s390/crypto/ap_bus.c
> > @@ -208,7 +208,6 @@ static inline int ap_query_configuration(struct ap_config_info *info)
> >  		return -EINVAL;
> >  	return ap_qci(info);
> >  }
> > -EXPORT_SYMBOL(ap_query_configuration);
> >  
> >  /**
> >   * ap_init_configuration(): Allocate and query configuration array.
> This function was exported a while ago for KVM code. However, never used.
> So removing the export is the right thing. Thanks Denis
> 
> Heiko/Vasily will you pick this patch please?
> 
> Reviewed-by: Harald Freudenberger <freude@...ux.ibm.com>
> 

Applied, thanks.