linux-kernel - Re: [PATCH v2 2/2] udf: support 2048-byte spacing of VRS descriptors on 4K media

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 12 Jul 2019 11:34:38 +0200
From:   Jan Kara <jack@...e.cz>
To:     Steve Magnani <steve.magnani@...idescorp.com>
Cc:     Jan Kara <jack@...e.cz>,
        "Steven J . Magnani" <steve@...idescorp.com>,
        Pali Rohár <pali.rohar@...il.com>,
        Jan Kara <jack@...e.com>, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] udf: support 2048-byte spacing of VRS descriptors
 on 4K media

On Thu 11-07-19 10:56:52, Steve Magnani wrote:
> On 7/11/19 10:04 AM, Jan Kara wrote:
> > Thanks for the patches! I've added them to my tree and somewhat simplified
> > the logic since we don't really care about nsr 2 vs 3 or whether we
> > actually saw BEA or not. Everything seems to work fine for me but I'd
> > appreciate if you could doublecheck - the result is pushed out to
> > 
> > git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git for_next
> > 
> Tested-by: Steven J. Magnani <steve@...idescorp.com>
> 
> The rework is more permissive than what you had suggested initially
> (conditioning acceptance of a noncompliant NSR on a preceding BEA).
> I had also tried to code the original so that a malformed 2048-byte
> interval VRS would not be accepted. But the simplifications do make
> the code easier to follow...

Yeah, it's simpler to follow and we do this check just to see whether this
may be a valid UDF media before doing more expensive probing. So I don't
think that the code being more permissive matters. Thanks for testing!

								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR