linux-kernel - Re: [EXT] Re: Re: [PATCH] media: v4l: Add packed YUV444 24bpp pixel format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1562936544.9511.25.camel@nxp.com>
Date:   Fri, 12 Jul 2019 13:02:24 +0000
From:   Mirela Rabulea <mirela.rabulea@....com>
To:     "paul.kocialkowski@...tlin.com" <paul.kocialkowski@...tlin.com>
CC:     dl-linux-imx <linux-imx@....com>,
        "s.nawrocki@...sung.com" <s.nawrocki@...sung.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "vivek.kasireddy@...el.com" <vivek.kasireddy@...el.com>,
        "boris.brezillon@...labora.com" <boris.brezillon@...labora.com>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        Robert Chiras <robert.chiras@....com>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "niklas.soderlund+renesas@...natech.se" 
        <niklas.soderlund+renesas@...natech.se>,
        "sakari.ailus@...ux.intel.com" <sakari.ailus@...ux.intel.com>,
        "hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>,
        "ezequiel@...labora.com" <ezequiel@...labora.com>
Subject: Re: [EXT] Re: Re: [PATCH] media: v4l: Add packed YUV444 24bpp pixel
 format

On Vi, 2019-07-12 at 11:21 +0200, paul.kocialkowski@...tlin.com wrote:
> Hi,
> 
> On Thu 11 Jul 19, 13:57, Mirela Rabulea wrote:
> > 
> > On Jo, 2019-07-11 at 10:18 +0200, Paul Kocialkowski wrote:
> > > 
> > > Caution: EXT Email
> > > 
> > > Hi,
> > > 
> > > On Wed 03 Jul 19, 18:15, Mirela Rabulea wrote:
> > > > 
> > > > 
> > > > The added format is V4L2_PIX_FMT_YUV24, this is a packed
> > > > YUV 4:4:4 format, with 8 bits for each component, 24 bits
> > > > per sample.
> > > > 
> > > > This format is used by the i.MX 8QuadMax and i.MX
> > > > 8DualXPlus/8QuadXPlus
> > > > JPEG encoder/decoder.
> > > So this format is not aligned to 32-bit words at all and we can
> > > expect
> > > to see cases where a single 32-bit word contains data for two
> > > pixels?
> > > 
> > > Nothing wrong with that, just checking whether I understood this
> > > right :)
> > > 
> > Hi Paul,
> > yes, your understanding is correct.
> Out of curiosity, is the JPEG block assmiliated to (one of) the
> Hantro VPUs
> or is it a totally different and unrelated hardware block?
> 
> Anyway the change looks good to me:
> Reviewed-by: Paul Kocialkowski <paul.kocialkowski@...tlin.com>
> 
> Cheers,
> 
> Paul

Hi Paul,
thanks for taking the time to review.
The JPEG decoder is a standalone core & wrapper, not assimilated to the
VPU. It is described in the reference manual here:
https://www.nxp.com/docs/en/reference-manual/IMX8DQXPRM.pdf
in chapters "15.6.3 JPEG Decoder (JPEGDEC)" and "15.6.5 JPEG Decoder
Wrapper".
The JPEG core is from a third party, and the wrapper from NXP.

Regards,
Mirela