lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 12 Jul 2019 23:54:37 +0900 From: Masahiro Yamada <yamada.masahiro@...ionext.com> To: Naohiro Aota <naohiro.aota@....com> Cc: Vincenzo Frascino <vincenzo.frascino@....com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, X86 ML <x86@...nel.org>, Andy Lutomirski <luto@...nel.org>, Thomas Gleixner <tglx@...utronix.de>, linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>, Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>, Peter Collingbourne <pcc@...gle.com> Subject: Re: [PATCH v2 1/2] x86/vdso: fix flip/flop vdso build bug On Fri, Jul 12, 2019 at 7:16 PM Naohiro Aota <naohiro.aota@....com> wrote: > > Two consecutive "make" on an already compiled kernel tree will show > different behavior: > > $ make > CALL scripts/checksyscalls.sh > CALL scripts/atomic/check-atomics.sh > DESCEND objtool > CHK include/generated/compile.h > VDSOCHK arch/x86/entry/vdso/vdso64.so.dbg > VDSOCHK arch/x86/entry/vdso/vdso32.so.dbg > Kernel: arch/x86/boot/bzImage is ready (#3) > Building modules, stage 2. > MODPOST 12 modules > > $ make > make > CALL scripts/checksyscalls.sh > CALL scripts/atomic/check-atomics.sh > DESCEND objtool > CHK include/generated/compile.h > VDSO arch/x86/entry/vdso/vdso64.so.dbg > OBJCOPY arch/x86/entry/vdso/vdso64.so > VDSO2C arch/x86/entry/vdso/vdso-image-64.c > CC arch/x86/entry/vdso/vdso-image-64.o > VDSO arch/x86/entry/vdso/vdso32.so.dbg > OBJCOPY arch/x86/entry/vdso/vdso32.so > VDSO2C arch/x86/entry/vdso/vdso-image-32.c > CC arch/x86/entry/vdso/vdso-image-32.o > AR arch/x86/entry/vdso/built-in.a > AR arch/x86/entry/built-in.a > AR arch/x86/built-in.a > GEN .version > CHK include/generated/compile.h > UPD include/generated/compile.h > CC init/version.o > AR init/built-in.a > LD vmlinux.o > <snip> > > This is causing "LD vmlinux" once every two times even without any > modifications. This is the same bug fixed in commit 92a4728608a8 > ("x86/boot: Fix if_changed build flip/flop bug"). We cannot use two > "if_changed" in one target. Fix this build bug by merging two commands into > one function. > > Cc: Masahiro Yamada <yamada.masahiro@...ionext.com> > Fixes: 7ac870747988 ("x86/vdso: Switch to generic vDSO implementation") > Signed-off-by: Naohiro Aota <naohiro.aota@....com> > --- Reviewed-by: Masahiro Yamada <yamada.masahiro@...ionext.com> -- Best Regards Masahiro Yamada
Powered by blists - more mailing lists