[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e0c38e99-7a01-7a84-2030-6cb963452e81@linux.alibaba.com>
Date: Fri, 12 Jul 2019 11:17:31 +0800
From: 王贇 <yun.wang@...ux.alibaba.com>
To: Peter Zijlstra <peterz@...radead.org>
Cc: hannes@...xchg.org, mhocko@...nel.org, vdavydov.dev@...il.com,
Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
linux-mm@...ck.org, mcgrof@...nel.org, keescook@...omium.org,
linux-fsdevel@...r.kernel.org, cgroups@...r.kernel.org,
Mel Gorman <mgorman@...e.de>, riel@...riel.com
Subject: Re: [PATCH 2/4] numa: append per-node execution info in
memory.numa_stat
On 2019/7/11 下午9:45, Peter Zijlstra wrote:
> On Wed, Jul 03, 2019 at 11:29:15AM +0800, 王贇 wrote:
>
>> +++ b/include/linux/memcontrol.h
>> @@ -190,6 +190,7 @@ enum memcg_numa_locality_interval {
>>
>> struct memcg_stat_numa {
>> u64 locality[NR_NL_INTERVAL];
>> + u64 exectime;
>
> Maybe call the field jiffies, because that's what it counts.
Sure, will be in next version.
Regards,
Michael Wang
>
>> };
>>
>> #endif
>> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
>> index 2edf3f5ac4b9..d5f48365770f 100644
>> --- a/mm/memcontrol.c
>> +++ b/mm/memcontrol.c
>> @@ -3575,6 +3575,18 @@ static int memcg_numa_stat_show(struct seq_file *m, void *v)
>> seq_printf(m, " %u", jiffies_to_msecs(sum));
>> }
>> seq_putc(m, '\n');
>> +
>> + seq_puts(m, "exectime");
>> + for_each_online_node(nr) {
>> + int cpu;
>> + u64 sum = 0;
>> +
>> + for_each_cpu(cpu, cpumask_of_node(nr))
>> + sum += per_cpu(memcg->stat_numa->exectime, cpu);
>> +
>> + seq_printf(m, " %llu", jiffies_to_msecs(sum));
>> + }
>> + seq_putc(m, '\n');
>> #endif
>>
>> return 0;
Powered by blists - more mailing lists