lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 12 Jul 2019 11:30:27 -0400 From: Qian Cai <cai@....pw> To: mpe@...erman.id.au Cc: paulus@...ba.org, benh@...nel.crashing.org, tyreld@...ux.vnet.ibm.com, joe@...ches.com, linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v3] powerpc/setup_64: fix -Wempty-body warnings Ping. On Fri, 2019-06-28 at 10:03 -0400, Qian Cai wrote: > At the beginning of setup_64.c, it has, > > #ifdef DEBUG > #define DBG(fmt...) udbg_printf(fmt) > #else > #define DBG(fmt...) > #endif > > where DBG() could be compiled away, and generate warnings, > > arch/powerpc/kernel/setup_64.c: In function 'initialize_cache_info': > arch/powerpc/kernel/setup_64.c:579:49: warning: suggest braces around > empty body in an 'if' statement [-Wempty-body] > DBG("Argh, can't find dcache properties !\n"); > ^ > arch/powerpc/kernel/setup_64.c:582:49: warning: suggest braces around > empty body in an 'if' statement [-Wempty-body] > DBG("Argh, can't find icache properties !\n"); > > Fix it by using the no_printk() macro, and make sure that format and > argument are always verified by the compiler. > > Suggested-by: Tyrel Datwyler <tyreld@...ux.vnet.ibm.com> > Suggested-by: Joe Perches <joe@...ches.com> > Signed-off-by: Qian Cai <cai@....pw> > --- > > v3: Use no_printk() macro, and make sure that format and argument are always > verified by the compiler using a more generic form ##__VA_ARGS__ per Joe. > > v2: Fix it by using a NOP while loop per Tyrel. > > arch/powerpc/kernel/setup_64.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c > index 44b4c432a273..cea933a43f0a 100644 > --- a/arch/powerpc/kernel/setup_64.c > +++ b/arch/powerpc/kernel/setup_64.c > @@ -69,9 +69,9 @@ > #include "setup.h" > > #ifdef DEBUG > -#define DBG(fmt...) udbg_printf(fmt) > +#define DBG(fmt, ...) udbg_printf(fmt, ##__VA_ARGS__) > #else > -#define DBG(fmt...) > +#define DBG(fmt, ...) no_printk(fmt, ##__VA_ARGS__) > #endif > > int spinning_secondaries;
Powered by blists - more mailing lists