linux-kernel - RE: [PATCH] PCI: pci-hyperv: fix build errors on non-SYSFS config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR21MB133723E9D1FA8BA0006E06FECAF20@DM6PR21MB1337.namprd21.prod.outlook.com>
Date:   Fri, 12 Jul 2019 16:04:17 +0000
From:   Haiyang Zhang <haiyangz@...rosoft.com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        linux-pci <linux-pci@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
CC:     Matthew Wilcox <willy@...radead.org>,
        Jake Oshins <jakeo@...rosoft.com>,
        KY Srinivasan <kys@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        Sasha Levin <sashal@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Dexuan Cui <decui@...rosoft.com>
Subject: RE: [PATCH] PCI: pci-hyperv: fix build errors on non-SYSFS config



> -----Original Message-----
> From: Randy Dunlap <rdunlap@...radead.org>
> Sent: Friday, July 12, 2019 11:53 AM
> To: linux-pci <linux-pci@...r.kernel.org>; LKML <linux-
> kernel@...r.kernel.org>
> Cc: Matthew Wilcox <willy@...radead.org>; Jake Oshins
> <jakeo@...rosoft.com>; KY Srinivasan <kys@...rosoft.com>; Haiyang
> Zhang <haiyangz@...rosoft.com>; Stephen Hemminger
> <sthemmin@...rosoft.com>; Stephen Hemminger
> <stephen@...workplumber.org>; Sasha Levin <sashal@...nel.org>; Bjorn
> Helgaas <bhelgaas@...gle.com>; Dexuan Cui <decui@...rosoft.com>
> Subject: [PATCH] PCI: pci-hyperv: fix build errors on non-SYSFS config
> 
> From: Randy Dunlap <rdunlap@...radead.org>
> 
> Fix build errors when building almost-allmodconfig but with SYSFS
> not set (not enabled).  Fixes these build errors:
> 
> ERROR: "pci_destroy_slot" [drivers/pci/controller/pci-hyperv.ko] undefined!
> ERROR: "pci_create_slot" [drivers/pci/controller/pci-hyperv.ko] undefined!
> 
> drivers/pci/slot.o is only built when SYSFS is enabled, so
> pci-hyperv.o has an implicit dependency on SYSFS.
> Make that explicit.
> 
> Also, depending on X86 && X86_64 is not needed, so just change that
> to depend on X86_64.
> 
> Fixes: a15f2c08c708 ("PCI: hv: support reporting serial number as slot
> information")
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Matthew Wilcox <willy@...radead.org>
> Cc: Jake Oshins <jakeo@...rosoft.com>
> Cc: "K. Y. Srinivasan" <kys@...rosoft.com>
> Cc: Haiyang Zhang <haiyangz@...rosoft.com>
> Cc: Stephen Hemminger <sthemmin@...rosoft.com>
> Cc: Stephen Hemminger <stephen@...workplumber.org>
> Cc: Sasha Levin <sashal@...nel.org>
> Cc: Bjorn Helgaas <bhelgaas@...gle.com>
> Cc: linux-pci@...r.kernel.org
> Cc: linux-hyperv@...r.kernel.org
> Cc: Dexuan Cui <decui@...rosoft.com>
> ---
> v3: corrected Fixes: tag [Dexuan Cui <decui@...rosoft.com>]
>     This is the Microsoft-preferred version of the patch.
> 
>  drivers/pci/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- lnx-52.orig/drivers/pci/Kconfig
> +++ lnx-52/drivers/pci/Kconfig
> @@ -181,7 +181,7 @@ config PCI_LABEL
> 
>  config PCI_HYPERV
>          tristate "Hyper-V PCI Frontend"
> -        depends on X86 && HYPERV && PCI_MSI && PCI_MSI_IRQ_DOMAIN
> && X86_64
> +        depends on X86_64 && HYPERV && PCI_MSI &&
> PCI_MSI_IRQ_DOMAIN && SYSFS
>          help
>            The PCI device frontend driver allows the kernel to import arbitrary
>            PCI devices from a PCI backend to support PCI driver domains.
> 

Reviewed-by: Haiyang Zhang <haiyangz@...rosoft.com>