linux-kernel - Re: [PATCH] proc: Fix uninitialized byte read in get_mm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190712163625.GF21989@redhat.com>
Date:   Fri, 12 Jul 2019 18:36:26 +0200
From:   Oleg Nesterov <oleg@...hat.com>
To:     Alexey Izbyshev <izbyshev@...ras.ru>
Cc:     Alexey Dobriyan <adobriyan@...il.com>,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        security@...nel.org
Subject: Re: [PATCH] proc: Fix uninitialized byte read in get_mm_cmdline()

On 07/12, Alexey Izbyshev wrote:
>
> --- a/fs/proc/base.c
> +++ b/fs/proc/base.c
> @@ -275,6 +275,8 @@ static ssize_t get_mm_cmdline(struct mm_struct *mm, char __user *buf,
>  		if (got <= offset)
>  			break;
>  		got -= offset;
> +		if (got < size)
> +			size = got;

Acked-by: Oleg Nesterov <oleg@...hat.com>