linux-kernel - Re: [PATCH 4/8] perf evsel: Do not rely on errno values for precise

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 13 Jul 2019 15:42:40 +0300
From:   Konstantin Kharlamov <hi-angel@...dex.ru>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Ingo Molnar <mingo@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Clark Williams <williams@...hat.com>,
        linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Quentin Monnet <quentin.monnet@...ronome.com>,
        Kim Phillips <kim.phillips@....com>,
        Arnaldo Carvalho de Melo <acme@...hat.com>
Subject: Re: [PATCH 4/8] perf evsel: Do not rely on errno values for
 precise_ip fallback

Thank you very much! Just wondering, would it maybe worth to backport 
the fix to stable kernel too?

В Пн, июл 8, 2019 at 12:42, Arnaldo Carvalho de Melo 
<acme@...nel.org> написал:
> From: Jiri Olsa <jolsa@...nel.org>
> 
> Konstantin reported problem with default perf record command, which
> fails on some AMD servers, because of the default maximum precise
> config.
> 
> The current fallback mechanism counts on getting ENOTSUP errno for
> precise_ip fails, but that's not the case on some AMD servers.
> 
> We can fix this by removing the errno check completely, because the
> precise_ip fallback is separated. We can just try  (if requested by
> evsel->precise_max) all possible precise_ip, and if one succeeds we 
> win,
> if not, we continue with standard fallback.
> 
> Reported-by: Konstantin Kharlamov <Hi-Angel@...dex.ru>
> Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
> Cc: Andi Kleen <ak@...ux.intel.com>
> Cc: Namhyung Kim <namhyung@...nel.org>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Quentin Monnet <quentin.monnet@...ronome.com>
> Cc: Kim Phillips <kim.phillips@....com>
> Link: http://lkml.kernel.org/r/20190703080949.10356-1-jolsa@kernel.org
> Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
> ---
>  tools/perf/util/evsel.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> index 4a5947625c5c..69beb9f80f07 100644
> --- a/tools/perf/util/evsel.c
> +++ b/tools/perf/util/evsel.c
> @@ -1785,14 +1785,8 @@ static int perf_event_open(struct perf_evsel 
> *evsel,
>  		if (fd >= 0)
>  			break;
> 
> -		/*
> -		 * Do quick precise_ip fallback if:
> -		 *  - there is precise_ip set in perf_event_attr
> -		 *  - maximum precise is requested
> -		 *  - sys_perf_event_open failed with ENOTSUP error,
> -		 *    which is associated with wrong precise_ip
> -		 */
> -		if (!precise_ip || !evsel->precise_max || (errno != ENOTSUP))
> +		/* Do not try less precise if not requested. */
> +		if (!evsel->precise_max)
>  			break;
> 
>  		/*
> --
> 2.20.1
>