linux-kernel - Re: [alsa-devel] [PATCH] sound: pci: emu10k1: Remove unneeded variable "change"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <s5hzhlhg77y.wl-tiwai@suse.de>
Date:   Sat, 13 Jul 2019 19:44:17 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     " Wasko, Michal " <michal.wasko@...ux.intel.com>
Cc:     <alsa-devel@...a-project.org>,
        Hariprasad Kelam <hariprasad.kelam@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        Allison Randal <allison@...utok.net>,
        Jaroslav Kysela <perex@...ex.cz>,
        Richard Fontana <rfontana@...hat.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [alsa-devel] [PATCH] sound: pci: emu10k1: Remove unneeded variable "change"

On Fri, 12 Jul 2019 10:06:23 +0200,
 Wasko, Michal  wrote:
> 
> 
> On 7/11/2019 7:17 PM, Hariprasad Kelam wrote:
> 
>     fix below issue reported by coccicheck
>     sound/pci/emu10k1/emu10k1x.c:1077:5-11: Unneeded variable: "change".
>     Return "0" on line 1092
>     
>     Signed-off-by: Hariprasad Kelam <hariprasad.kelam@...il.com>
>     
> Since the  function always return 0 and you perform code clean-up then
> maybe it would be a good idea to just change function to void instead
> of returning int value which does not seem to have use.

No, it's a callback function.


Takashi