linux-kernel - Re: [PATCH 02/14] iio: adc: sc27xx: Replace devm_add_action() followed by failure action with devm_add_action_or

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 14 Jul 2019 15:51:57 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Fuqian Huang <huangfq.daxian@...il.com>
Cc:     freeman.liu@...eadtrum.com, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/14] iio: adc: sc27xx: Replace devm_add_action()
 followed by failure action with devm_add_action_or_reset()

On Mon,  8 Jul 2019 20:32:43 +0800
Fuqian Huang <huangfq.daxian@...il.com> wrote:

> devm_add_action_or_reset() is introduced as a helper function which 
> internally calls devm_add_action(). If devm_add_action() fails 
> then it will execute the action mentioned and return the error code.
> This reduce source code size (avoid writing the action twice) 
> and reduce the likelyhood of bugs.
> 
> Signed-off-by: Fuqian Huang <huangfq.daxian@...il.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.

Thanks,

Jonathan

> ---
>  drivers/iio/adc/sc27xx_adc.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/iio/adc/sc27xx_adc.c b/drivers/iio/adc/sc27xx_adc.c
> index ec86f640e963..d7ca002cbb17 100644
> --- a/drivers/iio/adc/sc27xx_adc.c
> +++ b/drivers/iio/adc/sc27xx_adc.c
> @@ -546,10 +546,9 @@ static int sc27xx_adc_probe(struct platform_device *pdev)
>  		return -ENXIO;
>  	}
>  
> -	ret = devm_add_action(dev, sc27xx_adc_free_hwlock,
> +	ret = devm_add_action_or_reset(dev, sc27xx_adc_free_hwlock,
>  			      sc27xx_data->hwlock);
>  	if (ret) {
> -		sc27xx_adc_free_hwlock(sc27xx_data->hwlock);
>  		dev_err(dev, "failed to add hwspinlock action\n");
>  		return ret;
>  	}
> @@ -563,9 +562,8 @@ static int sc27xx_adc_probe(struct platform_device *pdev)
>  		return ret;
>  	}
>  
> -	ret = devm_add_action(dev, sc27xx_adc_disable, sc27xx_data);
> +	ret = devm_add_action_or_reset(dev, sc27xx_adc_disable, sc27xx_data);
>  	if (ret) {
> -		sc27xx_adc_disable(sc27xx_data);
>  		dev_err(dev, "failed to add ADC disable action\n");
>  		return ret;
>  	}