linux-kernel - Re: [PATCH] iio: adc: gyroadc: fix uninitialized return code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190714160908.7443eca6@archlinux>
Date:   Sun, 14 Jul 2019 16:09:08 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Wolfram Sang <wsa@...-dreams.de>
Cc:     Marek Vasut <marek.vasut@...il.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Arnd Bergmann <arnd@...db.de>, stable <stable@...r.kernel.org>,
        Marek Vasut <marek.vasut+renesas@...il.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Simon Horman <horms+renesas@...ge.net.au>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Rob Herring <robh@...nel.org>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        linux-iio@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iio: adc: gyroadc: fix uninitialized return code

On Thu, 4 Jul 2019 21:55:58 +0200
Wolfram Sang <wsa@...-dreams.de> wrote:

> > >> This is correct but missing that the above 'return ret' is broken, too.
> > >> ret is initialized but 0 in that case.  
> > > 
> > > Nice catch! Oh well, given enough eyeballs, ...  
> > 
> > I don't think ret is initialized, reg is, not ret .  
> 
> It is initialized for the broken 'return ret' *above* the one which gets
> rightfully fixed in this patch.
> 

Agreed, 2 broken cases and this is only fixing the second one.
I'm expecting a v2 of this patch which fixes them both, so 
won't apply this v1.

Thanks,

Jonathan