linux-kernel - Re: [PATCH] driver: block: nbd: Replace magic number 9 with SECTOR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 14 Jul 2019 01:09:33 -0300
From:   Marcos Paulo de Souza <marcos.souza.org@...il.com>
To:     linux-kernel@...r.kernel.org
Cc:     Marcos Paulo de Souza <mpdesouza@...e.com>,
        Josef Bacik <josef@...icpanda.com>,
        Jens Axboe <axboe@...nel.dk>,
        "open list:NETWORK BLOCK DEVICE (NBD)" <linux-block@...r.kernel.org>,
        "open list:NETWORK BLOCK DEVICE (NBD)" <nbd@...er.debian.org>
Subject: Re: [PATCH] driver: block: nbd: Replace magic number 9 with
 SECTOR_SHIFT

ping?

On Tue, Jul 02, 2019 at 07:55:21PM -0300, Marcos Paulo de Souza wrote:
> ping?
> 
> On Mon, Jun 24, 2019 at 01:09:33PM -0300, Marcos Paulo de Souza wrote:
> > set_capacity expects the disk size in sectors of 512 bytes, and changing
> > the magic number 9 to SECTOR_SHIFT clarifies this intent.
> > 
> > Signed-off-by: Marcos Paulo de Souza <mpdesouza@...e.com>
> > ---
> >  drivers/block/nbd.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
> > index 3a9bca3aa093..fd3bc061c600 100644
> > --- a/drivers/block/nbd.c
> > +++ b/drivers/block/nbd.c
> > @@ -288,7 +288,7 @@ static void nbd_size_update(struct nbd_device *nbd)
> >  	}
> >  	blk_queue_logical_block_size(nbd->disk->queue, config->blksize);
> >  	blk_queue_physical_block_size(nbd->disk->queue, config->blksize);
> > -	set_capacity(nbd->disk, config->bytesize >> 9);
> > +	set_capacity(nbd->disk, config->bytesize >> SECTOR_SHIFT);
> >  	if (bdev) {
> >  		if (bdev->bd_disk) {
> >  			bd_set_size(bdev, config->bytesize);
> > -- 
> > 2.21.0
> >