linux-kernel - Re: [PATCH v2] staging: iio: ad7192: create of_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190714173050.2b6306a0@archlinux>
Date:   Sun, 14 Jul 2019 17:30:50 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Bárbara Fernandes <barbara.fernandes@....br>
Cc:     lars@...afoo.de, Michael.Hennerich@...log.com,
        stefan.popa@...log.com, knaack.h@....de, pmeerw@...erw.net,
        gregkh@...uxfoundation.org, linux-iio@...r.kernel.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        kernel-usp@...glegroups.com, Wilson Sales <spoonm@...onm.org>
Subject: Re: [PATCH v2] staging: iio: ad7192: create of_device_id array

On Fri, 28 Jun 2019 16:49:22 -0300
Bárbara Fernandes <barbara.fernandes@....br> wrote:

> Create list of compatible device ids to be matched with those stated in
> the device tree.
> 
> Signed-off-by: Bárbara Fernandes <barbara.fernandes@....br>
> Signed-off-by: Wilson Sales <spoonm@...onm.org>
> Co-developed by: Wilson Sales <spoonm@...onm.org>
> ---
Patch is fine and applied to the togreg branch of iio.git.

Only thing to note is that reviewers and maintainers often have
poor memories (or are jet lagged which is my excuse today!)
so it helps to put a change log here under the ---

Thanks,

Jonathan

>  drivers/staging/iio/adc/ad7192.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> index 3d74da9d37e7..70118db98d94 100644
> --- a/drivers/staging/iio/adc/ad7192.c
> +++ b/drivers/staging/iio/adc/ad7192.c
> @@ -810,11 +810,23 @@ static const struct spi_device_id ad7192_id[] = {
>  	{"ad7195", ID_AD7195},
>  	{}
>  };
> +
>  MODULE_DEVICE_TABLE(spi, ad7192_id);
>  
> +static const struct of_device_id ad7192_of_match[] = {
> +	{ .compatible = "adi,ad7190" },
> +	{ .compatible = "adi,ad7192" },
> +	{ .compatible = "adi,ad7193" },
> +	{ .compatible = "adi,ad7195" },
> +	{}
> +};
> +
> +MODULE_DEVICE_TABLE(of, ad7192_of_match);
> +
>  static struct spi_driver ad7192_driver = {
>  	.driver = {
>  		.name	= "ad7192",
> +		.of_match_table = ad7192_of_match,
>  	},
>  	.probe		= ad7192_probe,
>  	.remove		= ad7192_remove,