linux-kernel - Re: [PATCH] proc: revert /proc/*/cmdline rewrite

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHk-=wjTmLQuByQmd1-bqN+piBaEMiJCjwLQOXqO5A+mffTwpQ@mail.gmail.com>
Date:   Sat, 13 Jul 2019 22:02:15 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     "Eric W. Biederman" <ebiederm@...ssion.com>
Cc:     Alexey Dobriyan <adobriyan@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Alexey Izbyshev <izbyshev@...ras.ru>,
        Oleg Nesterov <oleg@...hat.com>,
        Michal Kubecek <mkubecek@...e.cz>, shasta@...corp.com,
        Linux List Kernel Mailing <linux-kernel@...r.kernel.org>,
        Security Officers <security@...nel.org>
Subject: Re: [PATCH] proc: revert /proc/*/cmdline rewrite

[ Apparently this thread wasn't on the lists, and I didn't even
notice. So re-sending the patches ]

On Sat, Jul 13, 2019 at 9:16 PM Eric W. Biederman <ebiederm@...ssion.com> wrote:
> Given that this fixes a regression and a bug.
>
> Acked-by: "Eric W. Biederman" <ebiederm@...ssion.com>

I'd much rather start from scratch. Like the attached.

Alexey Izbyshev has a third patch that then limits the setproctitle()
case to only allow looking into the env[] area, which looks
reasonable.

           Linus

View attachment "0001-proc-pid-cmdline-remove-all-the-special-cases.patch" of type "text/x-patch" (3739 bytes)

View attachment "0002-proc-pid-cmdline-add-back-the-setproctitle-special-c.patch" of type "text/x-patch" (2855 bytes)