linux-kernel - Re: [PATCH 1/2] ASoC: samsung: odroid: fix an use-after-free issue for codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0eeabac6-edbd-b829-817f-ffff87e1a825@web.de>
Date:   Sun, 14 Jul 2019 10:47:20 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Wen Yang <wen.yang99@....com.cn>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        alsa-devel@...a-project.org
Cc:     Cheng Shengyu <cheng.shengyu@....com.cn>,
        Jaroslav Kysela <perex@...ex.cz>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Sangbeom Kim <sbkim73@...sung.com>,
        Sylwester Nawrocki <s.nawrocki@...sung.com>,
        Takashi Iwai <tiwai@...e.com>,
        Xue Zhihong <xue.zhihong@....com.cn>,
        Yi Wang <wang.yi59@....com.cn>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 1/2] ASoC: samsung: odroid: fix an use-after-free issue
 for codec

> @@ -317,6 +316,7 @@ static int odroid_audio_probe(struct platform_device *pdev)

>  		goto err_put_clk_i2s;

>  	}

>

> +	of_node_put(codec);


I would prefer to avoid a bit of duplicate source code also at this place.
Thus I would find a statement like “goto put_node;” more appropriate here.


>  	return 0;

>

>  err_put_clk_i2s:



Regards,
Markus