linux-kernel - Re: [PATCH] IIO: stm32: Remove quadrature related functions from trigger driver

Open Source and information security mailing list archives

Date:   Sun, 14 Jul 2019 11:09:01 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     William Breathitt Gray <vilhelm.gray@...il.com>
Cc:     Benjamin Gaignard <benjamin.gaignard@...com>,
        Benjamin Gaignard <benjamin.gaignard@...aro.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Alexandre Torgue <alexandre.torgue@...com>,
        linux-iio@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Hartmut Knaack <knaack.h@....de>,
        Fabrice Gasnier <fabrice.gasnier@...com>,
        linux-stm32@...md-mailman.stormreply.com,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] IIO: stm32: Remove quadrature related functions from
 trigger driver

On Thu, 11 Jul 2019 21:16:20 +0900
William Breathitt Gray <vilhelm.gray@...il.com> wrote:

> On Thu, Jul 11, 2019 at 02:12:27PM +0200, Benjamin Gaignard wrote:
> > Le jeu. 11 juil. 2019 à 13:51, William Breathitt Gray
> > <vilhelm.gray@...il.com> a écrit :  
> > >
> > > On Tue, May 07, 2019 at 11:12:24AM +0200, Benjamin Gaignard wrote:  
> > > > Quadrature feature is now hosted on it own framework.
> > > > Remove quadrature related code from stm32-trigger driver to avoid
> > > > code duplication and simplify the ABI.
> > > >
> > > > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@...com>  
> > >
> > > What is the status of this patch? Are there any objections currently for
> > > its inclusion?  
> > 
> > You were the only one asking for more details about it :-)
> > If you agree I think that Jonathan can merge it.
> > 
> > Benjamin  
> > >
> > > William Breathitt Gray
> > >
> > > _______________________________________________
> > > linux-arm-kernel mailing list
> > > linux-arm-kernel@...ts.infradead.org
> > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel  
> 
> Yes, Jonathan please merge this if you have no objections, I hadn't
> realized I was delaying it.
> 
> Thank you,
> 
> William Breathitt Gray
One last thing...  This seems to be a userspace ABI change.  What
are our potential issues with users of this ABI?

It's not that costly to keep the code, though dropping the docs or
putting a depreciated note in them is probably a good idea.  Hence
I'm not totally convinced the risk of a regression is worth it.

If we think it's the sort of change no one will notice, then
fair enough we'll give it a go and cross our fingers.

Thanks,

Jonathan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives