linux-kernel - Re: [v3] staging: most: remove redundant print statement when kfifo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <27df9bec-dbd5-8267-8df2-4948ca14e6d4@web.de>
Date:   Sun, 14 Jul 2019 16:42:11 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Keyur Patel <iamkeyur96@...il.com>, devel@...verdev.osuosl.org,
        kernel-janitors@...r.kernel.org
Cc:     Christian Gromm <christian.gromm@...rochip.com>,
        Colin Ian King <colin.king@...onical.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Suresh Udipi <sudipi@...adit-jv.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [v3] staging: most: remove redundant print statement when
 kfifo_alloc fails

> This print statement is redundant as kfifo_alloc just calls kmalloc_array
> and without the __GFP_NOWARN flag, already does a dump_stack().

I suggest to omit the word “and” from this sentence.
Will any further wording adjustments become helpful for commit descriptions?


> Changes in v3:
> - fix checkpatch warrning
> ---

Please move such version information below the triple dashes without a typo.

Regards,
Markus