linux-kernel - Re: [v4,1/2] rtc/fsl: add FTM alarm driver as the wakeup source

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190715145637.GG4732@piout.net>
Date:   Mon, 15 Jul 2019 16:56:37 +0200
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Biwen Li <biwen.li@....com>
Cc:     a.zummo@...ertech.it, leoyang.li@....com, robh+dt@...nel.org,
        linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org,
        xiaobo.xie@....com, jiafei.pan@....com, ran.wang_1@....com,
        mark.rutland@....com, devicetree@...r.kernel.org
Subject: Re: [v4,1/2] rtc/fsl: add FTM alarm driver as the wakeup source

On 15/07/2019 18:15:19+0800, Biwen Li wrote:
> +	device_init_wakeup(&pdev->dev, true);
> +	rtc->rtc_dev = devm_rtc_device_register(&pdev->dev, "ftm-alarm",
> +							&ftm_rtc_ops,
> +							THIS_MODULE);

To be clear, I want you to not use devm_rtc_device_register and use
devm_rtc_allocate_device and rtc_register_device.

> +	if (IS_ERR(rtc->rtc_dev)) {
> +		dev_err(&pdev->dev, "can't register rtc device\n");
> +		return PTR_ERR(rtc->rtc_dev);
> +	}
> +

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com