linux-kernel - Re: [PATCH 18/22] objtool: Refactor jump table code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190715093840.GY3419@hirez.programming.kicks-ass.net>
Date:   Mon, 15 Jul 2019 11:38:40 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Josh Poimboeuf <jpoimboe@...hat.com>
Cc:     x86@...nel.org, linux-kernel@...r.kernel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Arnd Bergmann <arnd@...db.de>, Jann Horn <jannh@...gle.com>,
        Randy Dunlap <rdunlap@...radead.org>
Subject: Re: [PATCH 18/22] objtool: Refactor jump table code

On Sun, Jul 14, 2019 at 07:37:13PM -0500, Josh Poimboeuf wrote:
> Now that C jump tables are supported, call them "jump tables" instead of
> "switch tables".  Also rename some other variables, add comments, and
> simplify the code flow a bit.
> 
> Signed-off-by: Josh Poimboeuf <jpoimboe@...hat.com>
> ---
>  tools/objtool/check.c | 82 +++++++++++++++++++++++--------------------
>  tools/objtool/elf.c   |  2 +-
>  tools/objtool/elf.h   |  2 +-
>  3 files changed, 46 insertions(+), 40 deletions(-)
> 
> diff --git a/tools/objtool/check.c b/tools/objtool/check.c
> index a190a6e79a91..b21e9f7768d0 100644
> --- a/tools/objtool/check.c
> +++ b/tools/objtool/check.c
> @@ -627,7 +627,7 @@ static int add_jump_destinations(struct objtool_file *file)
>  			 * However this code can't completely replace the
>  			 * read_symbols() code because this doesn't detect the
>  			 * case where the parent function's only reference to a
> -			 * subfunction is through a switch table.
> +			 * subfunction is through a switch jump table.

s/switch// ?